imodeljs / frontend-sample-showcase

MIT License
17 stars 9 forks source link

Samples update #200

Closed dustinlebsock closed 3 years ago

dustinlebsock commented 3 years ago

Please go through the samples you have created/edited and review the functionality.

Bugs known:

Samples NOT updated:

Samples updated:

williamkbentley commented 3 years ago

Error in @bentley/monaco-editor v5.2.1...


Failed to compile.

./node_modules/@bentley/monaco-editor/lib/components/file-explorer/FileExplorer.js 172:54 Module parse failed: Unexpected token (172:54) File was processed with these loaders:

linasburneika commented 3 years ago

Error in @bentley/monaco-editor v5.2.1...

Failed to compile.

./node_modules/@bentley/monaco-editor/lib/components/file-explorer/FileExplorer.js 172:54 Module parse failed: Unexpected token (172:54) File was processed with these loaders:

* ./node_modules/babel-loader/lib/index.js

* ./node_modules/source-map-loader/dist/cjs.js
  You may need an additional loader to handle the result of these loaders.
  |     folder: folder,
  |     files: folders[folder],
currentFile: _removeDirname(activityState.active ?? "", folder) || undefined,

| onFileSelect: _onFileSelected, | active: _firstDirname(activityState.active || "") === folder,

This error is familiar to me, it's because of ?? null coalescing operator. I got it resolved in my standalone samples project by including additional babel plugins to config-override.js addExternalBabelPlugins("@babel/plugin-proposal-nullish-coalescing-operator", "@babel/plugin-proposal-optional-chaining")

williamkbentley commented 3 years ago

Error in @bentley/monaco-editor v5.2.1... Failed to compile. ./node_modules/@bentley/monaco-editor/lib/components/file-explorer/FileExplorer.js 172:54 Module parse failed: Unexpected token (172:54) File was processed with these loaders:

* ./node_modules/babel-loader/lib/index.js

* ./node_modules/source-map-loader/dist/cjs.js
  You may need an additional loader to handle the result of these loaders.
  |     folder: folder,
  |     files: folders[folder],
currentFile: _removeDirname(activityState.active ?? "", folder) || undefined,

| onFileSelect: _onFileSelected, | active: _firstDirname(activityState.active || "") === folder,

This error is familiar to me, it's because of ?? null coalescing operator. I got it resolved in my standalone samples project by including additional babel plugins to config-override.js addExternalBabelPlugins("@babel/plugin-proposal-nullish-coalescing-operator", "@babel/plugin-proposal-optional-chaining")

Not seeing this anymore with this branch's package-lock.json

dustinlebsock commented 3 years ago

There were times when the sample widget would not populate. After docking it or reloading the sample, it would be fine, but still happened around 1 in 5 times I opened a sample.

This issue is known and being worked on. The widget is being created and populated, it's size is just incorrect. You can manually resize to see the info, but it shouldn't be 'minimized' in the first place.

dustinlebsock commented 3 years ago

There were times when the sample widget would not populate. After docking it or reloading the sample, it would be fine, but still happened around 1 in 5 times I opened a sample.

This issue is known and being worked on. The widget is being created and populated, it's size is just incorrect. You can manually resize to see the info, but it shouldn't be 'minimized' in the first place.

Stefan is amazing and fixed this the moment I made the comment.