imodeljs / frontend-sample-showcase

MIT License
17 stars 9 forks source link

Necessary adjustments for the new Metrostation model #251

Closed williamkbentley closed 3 years ago

williamkbentley commented 3 years ago
williamkbentley commented 3 years ago

TODO: Elevation of Issue placement and views needs to be adjusted. The new Metrostation model is 3 meters higher than the old one.

williamkbentley commented 3 years ago

To use a clone of new Metrostation, edit SampleImodels.ts and change MetroStation = "Metrostation Sample 2",

williamkbentley commented 3 years ago

Is there a reason that you only updated the ViewSetup file in the @itwinjs-sandbox package, and not also the one under api?

I thought the one under api was for legacy (non iTwin-viewer) based samples, of which we have none.

Ellord207 commented 3 years ago

I thought the one under api was for legacy (non iTwin-viewer) based samples, of which we have none.

Okay, I assumed the file would have been deleted with the last of the legacy samples.

williamkbentley commented 3 years ago

I thought the one under api was for legacy (non iTwin-viewer) based samples, of which we have none.

Okay, I assumed the file would have been deleted with the last of the legacy samples.

Yeah, possibly it was overlooked. We can address that in a separate PR

BaoTon commented 3 years ago

The widget appears to always be disabled for serialize view sample:

image

williamkbentley commented 3 years ago

The widget appears to always be disabled for serialize view sample:

image

You need to edit SampleViewStates.ts. Change iModelId to b55dec38-d9b7-4029-9b9c-6b899151328f for Metrostation Sample... I'll make this change before merging