imodeljs / frontend-sample-showcase

MIT License
17 stars 9 forks source link

Scientific Visualization Sample #260

Closed KrishKash closed 3 years ago

KrishKash commented 3 years ago
CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

Josh-Schifter commented 3 years ago

Can we hide the animation timeline for the static visualizations? It makes it seem like those are 'broken'.

Josh-Schifter commented 3 years ago

@pmconne, please suggest a proper description for the readme.

pmconne commented 3 years ago

I'm seeing visual interference on the flat mesh. Maybe the grid is interfering with it? Please try a coarser grid.

You're going to get z-fighting no matter what, if you keep the mesh coplanar with the grid.

Josh-Schifter commented 3 years ago

You're going to get z-fighting no matter what, if you keep the mesh coplanar with the grid.

In that case, I suggest turning off the grid.

Josh-Schifter commented 3 years ago

We try to make the thumbnail match the initial state of the sample. I like the thumbnail you created. Please change the sample to choose that visualization by default.

pmconne commented 3 years ago

When I run this, the showcase loads (I can see the thumbnails and the viewport) but as soon as the code editor starts loading an uncaught exception kills the page.

log.js:21 [HMR] Waiting for update signal from WDS...
react-dom.development.js:24802 Download the React DevTools for a better development experience: https://fb.me/react-devtools
webpackHotDevClient.js:119 ./node_modules/source-map/lib/source-map/source-map-generator.js
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
printWarnings @ webpackHotDevClient.js:119
webpackHotDevClient.js:119 ./node_modules/source-map/lib/source-map/source-map-consumer.js
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
printWarnings @ webpackHotDevClient.js:119
webpackHotDevClient.js:119 ./node_modules/source-map/lib/source-map/source-node.js
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
printWarnings @ webpackHotDevClient.js:119
react-dom.development.js:11913 Uncaught Error: define cannot be used indirect
    at push../node_modules/webpack/buildin/amd-define.js.module.exports (amd-define.js:2)
    at Object.<anonymous> (source-map-generator.js:9)
    at Object../node_modules/source-map/lib/source-map/source-map-generator.js (source-map-generator.js:403)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Object../node_modules/source-map/lib/source-map.js (source-map.js:6)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../node_modules/@bentley/monaco-editor/lib/bundler/Bundler.js (Bundler.js:1)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../node_modules/@bentley/monaco-editor/lib/components/run-code-button/RunCodeButton.js (RunCodeButton.js:1)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../node_modules/@bentley/monaco-editor/lib/monaco-editor.js (monaco-editor.js:1)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../src/Components/SampleEditor/SampleEditorContext.tsx (SampleEditor.tsx:157)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
index.js:1451 The above error occurred in one of your React components:
    in Unknown (at SampleShowcase.tsx:60)
    in Suspense (at SampleShowcase.tsx:59)
    in div (created by InternalPane)
    in InternalPane (created by Pane)
    in Pane (at SampleShowcaseSplitPane.tsx:141)
    in PaneHandler (created by SplitScreen)
    in div (created by ForwardRef)
    in ForwardRef (created by SplitScreen)
    in SplitScreen (at SampleShowcaseSplitPane.tsx:140)
    in SampleShowcaseSplitPane (at SampleShowcaseViewHandler.tsx:35)
    in div (at SampleShowcaseViewHandler.tsx:34)
    in SampleShowcaseViewHandler (at SampleShowcase.tsx:94)
    in SampleShowcase (at App.tsx:19)
    in App (at src/index.tsx:14)

Consider adding an error boundary to your tree to customize error handling behavior.
Visit https://fb.me/react-error-boundaries to learn more about error boundaries.
console.<computed> @ index.js:1451
scheduler.development.js:174 Uncaught Error: define cannot be used indirect
    at push../node_modules/webpack/buildin/amd-define.js.module.exports (amd-define.js:2)
    at Object.<anonymous> (source-map-generator.js:9)
    at Object../node_modules/source-map/lib/source-map/source-map-generator.js (source-map-generator.js:403)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Object../node_modules/source-map/lib/source-map.js (source-map.js:6)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../node_modules/@bentley/monaco-editor/lib/bundler/Bundler.js (Bundler.js:1)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../node_modules/@bentley/monaco-editor/lib/components/run-code-button/RunCodeButton.js (RunCodeButton.js:1)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../node_modules/@bentley/monaco-editor/lib/monaco-editor.js (monaco-editor.js:1)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)
    at Module../src/Components/SampleEditor/SampleEditorContext.tsx (SampleEditor.tsx:157)
    at __webpack_require__ (bootstrap:789)
    at fn (bootstrap:150)