Closed kckst8 closed 4 years ago
I will note, one thing i strongly dislike about how linting is setup like this with linting done globally is it's impossible to decipher what's going on when linting. Ideally configs should be configured globally, but linting is done in packages individually so you can see what's happening.
The following is very unhelpful imo:
I will note, one thing i strongly dislike about how linting is setup like this with linting done globally is it's impossible to decipher what's going on when linting. Ideally configs should be configured globally, but linting is done in packages individually so you can see what's happening.
The following is very unhelpful imo:
I don't know. I think the errors are what's important and they are reported with filepaths. I don't know that I've personally ever looked/cared about what steps are actively running.
I considered individual but Rush does not make that easy. Even adding lint-staged in general was a bit of a hack. There is no "lerna run.." alternative in Rush. You can configure commands but those cannot be coded to fail a pre-commit properly.
The largest issue with global execution is performance, but I don't expect this repo to scale very much and it should not have javascript projects, so that should help keep the run time lower.
lgtm, i saw you had tested it out quite a bit already :) but i should probably test as well
If you wouldn't mind testing on Windows (assuming you're using Windows), I would appreciate it
lgtm, i saw you had tested it out quite a bit already :) but i should probably test as well
If you wouldn't mind testing on Windows (assuming you're using Windows), I would appreciate it
Worked well for me (on Windows) :)
ignore all of the test commits