search

imodeljs / itwin-viewer

Monorepo that contains the iTwin Viewer npm package and its related packages
MIT License
15 stars 13 forks source link

add missing peer deps, and fix cra template scss #67

Closed aruniverse closed 3 years ago

aruniverse commented 3 years ago

Fix scss so theres no gap below the viewer and the app takes up the entire screen. Add missing peer deps required by the introduction of the new tree-widget-react and property-grid react in the viewer. Bump property-grid-react

aruniverse commented 3 years ago

Why do we need to bump the min imjs version?

Because property-grid-react has a peer dep on ^2.9.2. Need to determine if that can be lowered or not on that pkg's end

kckst8 commented 3 years ago

Why do we need to bump the min imjs version?

Because property-grid-react has a peer dep on ^2.9.2. Need to determine if that can be lowered or not on that pkg's end

I would prefer we do that if possible. I haven't noticed any issues with the property grid running the sample app on 2.6.4. If we do need to bump, we should bump the min in the itv package as well

aruniverse commented 3 years ago

Why do we need to bump the min imjs version?

Because property-grid-react has a peer dep on ^2.9.2. Need to determine if that can be lowered or not on that pkg's end

I would prefer we do that if possible. I haven't noticed any issues with the property grid running the sample app on 2.6.4. If we do need to bump, we should bump the min in the itv package as well

Updated property-grid-react to have 2.6.0 as min supported version