search

imodeljs / itwin-viewer

Monorepo that contains the iTwin Viewer npm package and its related packages
MIT License
15 stars 13 forks source link

change REACT_APP prefixes to IMJS #68

Closed kckst8 closed 3 years ago

aruniverse commented 3 years ago

Actually one minor comment, did you test this out? I'm not sure if the env var is case sensitive or not. It looks like we support imjs_ not IMJS_, but could be wrong about that. See here

kckst8 commented 3 years ago

Actually one minor comment, did you test this out? I'm not sure if the env var is case sensitive or not. It looks like we support imjs_ not IMJS_, but could be wrong about that

I did test and it worked fine. I think we should fall in line with CRA (and node env vars in general) and keep them UCase