search

imogen-nell / SCL3300-TiltSesor

SCL3300-D01 3-axis inclinometer with angle output and digital SPI interface MuRata
0 stars 0 forks source link

Lots of println! #1

Open javerom opened 3 months ago

javerom commented 3 months ago

Can you limit the number of printlns used throughout? You may consider using the log crate to distinguish between what should be shown to the user (e.g. info! or error! or warn!) versus what is debug statements (debug! or trace!). This way, the user can control how much verbosity they want.

javerom commented 3 months ago

Looks like lots of good use of log now :)

I would convert some of the info! to debug! in, for example, areas where you are printing results of binary.

E.g. https://github.com/imogen-nell/SCL3300-TiltSesor/blob/1c66d1211154e6568207d1e4e52ad16ffb1d0606/src/tiltsensor.rs#L91