imogenkinsman / TwitterWithFragments

An android twitter app using fragments
1 stars 0 forks source link

[Android Bootcamp] Review my app #1

Open imogenkinsman opened 10 years ago

imogenkinsman commented 10 years ago

Ready to review.

The biggest thing I had trouble with was interaction between fragments and activities - I had a lot of nullpointerexception issues like when trying to attach handlers to views that hadn't been created yet, stuff like that.

The code needs to be cleaner and is a bit hacky in parts. I'm going to put more time in to do polish/features/cleanup for my portfolio.

/cc @nesquena @timothy1ee

imogenkinsman commented 10 years ago

Okay, class cleared up pretty much every question I had. I'm exposing public getters in my TweetsListFragment right now, so using an interface would be much cleaner. Also, did some reading about the life cycle when I ran into problems before, and your discussion (and reading the Cliffnotes) helps a ton. Thanks!

I heard you mention something offhand about like a layout that lets you swipe between fragments or something like that - was that a ViewPager? Group project ideas.

nesquena commented 10 years ago

Jade, :+1: nice work overall. A few notes after checking out the code:

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we covered the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Nov 11th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.

Okay, class cleared up pretty much every question I had.

Great!

I heard you mention something offhand about like a layout that lets you swipe between fragments or something like that - was that a ViewPager?

Yep ViewPager