search

imohitmayank / jaal

Your interactive network visualizing dashboard
MIT License
321 stars 41 forks source link

Node Filtering with Uppercase Letters #62

Closed dbrosnan08 closed 1 year ago

dbrosnan08 commented 1 year ago

Hey awesome work! I ran into an issue with node filtering for uppercase letters. If I have a node label 'AB12345', noticed that trying to filter for 'AB' excluded 'AB12345'.

looking at _callback_search_graph(), the condition is to find search_text in node['label'].lower(), so that searches for upper case letters fail.

Then again this does not seem to occur in your demos, so maybe i just set up the input dataframe wrong. anyway dont do this a lot but wanted to share an issue I experienced because my experience with jaal has been great so far

https://github.com/imohitmayank/jaal/blob/74a7d2cbe6195e55ad655b63d0099243712c1cda/jaal/jaal.py#L45

imohitmayank commented 1 year ago

Thanks for sharing this @dbrosnan08 , it seems we should do search_text.lower() there. https://github.com/imohitmayank/jaal/blob/74a7d2cbe6195e55ad655b63d0099243712c1cda/jaal/jaal.py#L45

imohitmayank commented 1 year ago

Hi @dbrosnan08 this is fixed now, please upgrade to latest version of jaal for this to work.