search

imor / uci

A thin wrapper on a uci chess engine
MIT License
33 stars 18 forks source link

goDepthCommand is implemented (issue #18) #21

Closed Scorpibear closed 7 years ago

Scorpibear commented 9 years ago

tested, works perfectly, please, merge and publish updated version to npm

imor commented 9 years ago

Thanks for the pull request. Just one concern -- I don't think parsing the score from the info line is a good idea. If you really need the score, it should be parsed and passed as an object to the infoHandler. Please make this change before I merge it.

Scorpibear commented 9 years ago

Hi imor,

Could you please point to the example how to do that?

2015-08-19 14:43 GMT+03:00 Raminder Singh notifications@github.com:

Thanks for the pull request. Just one concern -- I don't think parsing the score from the info line is a good idea. If you really need the score, it should be parsed and passed as an object to the infoHandler. Please make this change before I merge it.

— Reply to this email directly or view it on GitHub https://github.com/imor/uci/pull/21#issuecomment-132558390.

imor commented 9 years ago

Hi @Scorpibear

I've explained what I meant in the comments on the diff.