Dogfooding Fixes: Microcredit

impactMarket / app

impactMarket WebApp

https://app.impactmarket.com

Apache License 2.0

2 stars 1 forks source link

Dogfooding Fixes: Microcredit #498

Closed hugomarquesdev closed 1 year ago

hugomarquesdev commented 1 year ago

This PR fixes #

Changes

Notifications count on Sidebar
Remove notifications from store (redux)
Updating pages (repayments and approve/reject) now keeps the previous tabs selected / open
Add loading on signature button to prevent multiple clicks
Add Loan Application button on the dropdown of borrowers in Approve/Reject (it's hidden for now)
Add Unclaimed tab on Repayments
Translations

Tests

[x] Tested on mobile
[x] Tested on dektop

This PR should be manually tested by @obernardovieira @PauloSousapt , included on reviewers.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2023 11:37am

hugomarquesdev commented 1 year ago

But, if instead of using the notifications endpoint to get the count, you use the GET (or POST) /user, it's best. You can see here impactMarket/backend#774 it's in staging already.

oh, i didn't know it has already available 😅 i'll make that change

hugomarquesdev commented 1 year ago

But, if instead of using the notifications endpoint to get the count, you use the GET (or POST) /user, it's best. You can see here impactMarket/backend#774 it's in staging already.

done