impactlab / eemeter

‼️ MOVED TO https://github.com/openeemeter/eemeter - Core computation engine for the Open Energy Efficiency Meter
https://eemeter.readthedocs.io/
MIT License
25 stars 13 forks source link

Correct resampling of estimated timeseries #127

Closed philngo closed 8 years ago

philngo commented 8 years ago

This fixes an issue in which the estimated reading consolidation step for resampled (higher frequency) data was returning empty pandas timeseries, which caused downstream meters to fail with NaN and 0 values. The problem originated in the resample step, in which consumption_data.data was resampled, but consumption_data.estimated was not resampled, and returned an empty series.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling fb0e37bed90da68ee2c4c42fc4ebeaec9eee8576 on feature/fix-resampling-estimated into 3b1b8d3169a3ee412bb28894bab9ec1230f9d2d3 on develop.

marcrecurve commented 8 years ago

LGTM