Guest user can add progress report

impactoss / impactoss-server

IMPACT OSS - server-side application & API

https://demo.impactoss.org

MIT License

3 stars 8 forks source link

Guest user can add progress report #154

Open tmfrnz opened 7 years ago

tmfrnz commented 7 years ago

As a guest user

I can contribute information in form of progress reports to any indicator. The user assigned to the indicator (or the user assigned to the human rights body?) will be notified about the submitted report. (see https://github.com/impactoss/impactoss-server/issues/274)

tmfrnz commented 7 years ago

@ashbowe could you please clarify who should get notified:

the user assigned to the indicator the report is attached to, or
the users assigned to any associated human rights body (those that tag recommendations that are associated with actions that are associated with the indicator)?

tmfrnz commented 7 years ago

@ashbowe it may be beneficial to require the user to create an account first (anyone can register and will be assigned the Guest role) - will discuss with Chris (@barancw)

ashbowe commented 7 years ago

Hi Timo, the second of those two options - the user who has overall responsibility for that set of recommendations

tmfrnz commented 7 years ago

@ashbowe thank you for clarifying. Here some further thoughts:

In case an indicator is associated with an action associated with recommendations from different HR bodies (or an indicator is associated with multiple actions associated with recommendations from different HR bodies) more than one manager could be notified by email (as is also true with the planned email reminders)

Further if we are including SDGs, indicators associated with SDG targets, may not belong to any manager. In this case we may want to consider the option to disable public contribution for specific indicators (the SDG indicators) or assign users to SDGs as SDG managers.

ashbowe commented 7 years ago

I think it would be great to have an SDG manager but having the option to disable contributions would also be helpful. Having these two options would allow for greatest flexibility so I'd be keen for that if possible and not too much trouble!

tmfrnz commented 7 years ago

Have included SDG managers, so also SDG indicators should now have a manager

tmfrnz commented 7 years ago

@barancw i have started implementing this on the client. For the server we would need the following changes:

1. Allow report creation for guest users (ASAP)

[x] Allow a signed in guest to create (not update) a progress_report
[x] Update test case
[ ] Force draft: true.

2. Notify category manager about report creation (not that urgent)

see https://github.com/impactoss/impactoss-server/issues/274

tmfrnz commented 7 years ago

@barancw have managed to update policy and spec, only missing enforcement of draft state (true)