search

impactoss / impactoss-server

IMPACT OSS - server-side application & API
https://demo.impactoss.org
MIT License
3 stars 8 forks source link

Improve batch mode performance #256

Closed tmfrnz closed 7 years ago

tmfrnz commented 7 years ago

Papertrail is versioning the users table with every update, including when new tokens are stored from devise-token-auth, leading to poor performance when in sending many requests.

While disabling change_headers_on_each_request (https://github.com/dumparkltd/impactoss-server/commit/9aeb116aa70cc9858753f5cbd9dfcb3a54b2f8ab) is an effective workaround with regards to performance, it compromises security.

Better probably would be to have papertrail ignore the tokens field as suggested here https://github.com/lynndylanhurley/devise_token_auth/issues/922#issuecomment-318876450

See also https://github.com/airblade/paper_trail#2c-choosing-attributes-to-monitor

tmfrnz commented 7 years ago

having papertrail ignore the token field did not yield satisfactory improvment - turning off change_headers_on_each_request for now