Allow contributors to create progress reports for indicators.

impactoss / impactoss-server

IMPACT OSS - server-side application & API

https://demo.impactoss.org

MIT License

3 stars 8 forks source link

Allow contributors to create progress reports for indicators. #293

Closed parndt closed 6 years ago

parndt commented 6 years ago

This was changed in bb687a69339aaa3501f24140907e9a2135ffe4c5 for #154 so it makes sense to update the spec to allow for this because it will otherwise just keep failing.

parndt commented 6 years ago

It's worth noting that the original change was to allow guests the ability to create progress reports and that this had the side effect of allowing any contributor to create one. If that's incorrect we'll need to address that logic instead of just changing the spec.

tmfrnz commented 6 years ago

You are right @parndt! The update was a quick "temporary" hack to allow guest users to create progress reports (#154 ) however the spec was never updated. Ultimately the desired behaviour is:

guest users (and thus anyone) can create draft progress reports - this is currently only enforced in the client
assigned contributors, managers and admins can create public progress reports and make draft reports public