impactoss / impactoss-server

IMPACT OSS - server-side application & API
https://demo.impactoss.org
MIT License
3 stars 8 forks source link

Email with name #371

Closed tmfrnz closed 9 months ago

tmfrnz commented 9 months ago

@parndt not sure why the checks are passing but I assume we will also need to update the various mail.from tests in due_date_mailer_spec" to match the "email with name" https://github.com/impactoss/impactoss-server/blob/master/spec/mailers/due_date_mailer_spec.rb

parndt commented 9 months ago

@parndt not sure why the checks are passing but I assume we will also need to update the various mail.from tests in due_date_mailer_spec" to match the "email with name"

@tmfrnz are the checks passing here because CI doesn't have these values set in .github/workflows/main.yml so it's using the defaults, which the specs expect?