search

impactoss / impactoss-server

IMPACT OSS - server-side application & API
https://demo.impactoss.org
MIT License
3 stars 8 forks source link

Bug: recommendations lost their relationship to indicators via measures #385

Open tmfrnz opened 9 months ago

tmfrnz commented 9 months ago

When direct recommendation-indicator relationships were introduced, it appears that the indirect relationships were lost https://github.com/impactoss/impactoss-server/commit/501116a12b36b41a1ee2c5cbe8c4e9351fce056b#diff-d14c0ec254c5e8d561ec87771011fbb7f701d2b47501a8f5c5319ed1f504c8c6

These are needed to trigger overdue emails to category managers

tmfrnz commented 9 months ago

@parndt i have a work around in place, but would like you to clean this up:

the recommendation model should merge direct and indirect indicators, so that there is no need to change the category model (so category.indicators and category.due_dates would work both for indicators that are directly linked to recommendations and that are linked through measures

just updating this to reflect latest thinking:

category.due_dates should be derived from both :indicators (from recommendations) and :indicators_via_measures (from recommendations and their measures) https://github.com/impactoss/impactoss-server/blob/nz-justice-development/app/models/category.rb#L16