impactoss / impactoss-server

IMPACT OSS - server-side application & API
https://demo.impactoss.org
MIT License
3 stars 8 forks source link

improve fog-aws / s3 upload #393

Closed tmfrnz closed 4 months ago

tmfrnz commented 6 months ago
tmfrnz commented 6 months ago

hi @parndt, could you review this and clean it up where required?

the idea is that the signed url AWS returns is hidden from the client and we use the client URL instead (which is hosted in the same bucket)

now there is probably be a better way to do the URL replacement. also we should consider making it optional (from another ENV variable?) and also fix those failing checks

parndt commented 4 months ago

@tmfrnz how's this looking?

tmfrnz commented 4 months ago

@tmfrnz how's this looking?

happy to confirm that this appears to be working well on UAT