search

imperialCHEPI / healthgps

Global Health Policy Simulation model (Health-GPS)
https://imperialchepi.github.io/healthgps/
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

EBM: chicken and egg scenario #181

Open jamesturner246 opened 1 year ago

jamesturner246 commented 1 year ago

A few places in EnergyBalanceModel::simulate_person compute new state variables from other initial state variables, where they should probably be computed from other new state. For example, delta (used in EE) is computed using BW_0, when it should probably be computed using BW:

double delta = ((1.0 - beta_TEF) * PAL - 1.0) * RMR / BW_0;
//                                                    ^ should be BW?

Untangling this is non-trivial, since the new BW is currently indirectly a function of delta, but this just doesn't feel right. A possible solution (unverified) would be to recompute delta after BW is computed, and before EE is computed.

Will require liaison with the modelling team to discuss intention and solutions.

jamesturner246 commented 12 months ago

Another in the update phase: should height be updated before weight?

Height depends on weight, which itself depends on height...

jamesturner246 commented 12 months ago

Same in kevin hall initialisation: it goes weight, then, height, then kevin hall params (glycogen, ECF, etcetera)...

jackolney commented 10 months ago

Kevin Hall Framework.pdf – this might contain the answer?