search

imperialCHEPI / healthgps

Global Health Policy Simulation model (Health-GPS)
https://imperialchepi.github.io/healthgps/
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

[BUG] `KevinHall_India` example doesn't work with latest commit of HealthGPS #521

Closed alexdewar closed 1 month ago

alexdewar commented 1 month ago

Describe the bug

The version of HealthGPS on main no longer loads the KevinHall_India example, since #491. I think this is because of the new ExpectedTrend property, which doesn't exist in the example.

To Reproduce

Steps to reproduce the behavior:

Run HealthGPS.Console with heathgps-examples/KevinHall_India/model/Config.json.

Expected behavior

For the simulation to run, as it did before #491.

Software versions

Additional context

As I see it, there are two ways we can fix this:

  1. Add the missing property/properties to the example
  2. Change HealthGPS to fallback on the previous behaviour if the property isn't present

This is also probably a good illustration of why it would be handy to make regular releases for both healthgps and healthgps-examples (I appreciate this is hard when development is so constant though!).

Provided this problem isn't affecting @jzhu20, it's not that big of a deal, but it would be useful to fix it at some point when I come to writing JSON schemas for the model files.

Any thoughts @jamesturner246?

alexdewar commented 1 month ago

The HLM_India example isn't working either.

alexdewar commented 1 month ago

Superseded by https://github.com/imperialCHEPI/healthgps-examples/issues/28 and #531.