Closed SaranjeetKaur closed 2 months ago
Seems sensible to me!
Do we want to tag @jzhu20 as a reviewer? Up to you (and I guess you haven't done a PR before, @jzhu20?), but might be useful for these types of PRs.
Thanks @alexdewar! Yes, I have tagged @jzhu20 as a reviewer on this one. It would be helpful to have her inputs here.
Oh, I didn't spot that you'd already done it :facepalm:
Changes made:
risk-factors.R
,rf-diff.R
,inc-diff.R
,burden.R
, andinc-cum-diff.R
, there is a single file calledhealth-plots.R
.health-plots.R
contains several plotting functions:riskfactors()
,riskfactors_diff()
,inc_diff()
,inc_cum()
,burden_disease()
,life_exp()
.To be discussed with Jack and Jingmin:
inc_cum
have various values forelement_text(size = 10)
namely9.5/10/12
. Set10
as defaultriskfactors
hasscale_y_continuous(labels = scaleFUN)
as default, whereas it also usesscale_y_continuous(labels = scales::comma)
occasionallydalydiffcum
hascolor = "purple"
but inburden_disease
default is set tocolour = "#FF1493"
life_exp()
is a separate function fromburden_disease()
colour
,linewidth
for the geom_line, breaks, time, etc are hard-coded: it might help to provide them as arguments in the function, in case the user wants to change the values.To-do: