search

imperiumlabs / GeoFirestore-iOS

GeoFirestore for iOS - Realtime location queries with Firestore
MIT License
127 stars 46 forks source link

Fix infinite loop #3

Closed mainto closed 6 years ago

mainto commented 6 years ago

When I called removeAllObservers() and/or removeObserver(withHandle: GFSQueryHandle) on GFSQuery, It fall into infinite loop on reset() function. When for loop started, query variable keep getting nil and never exit from loop. So, I fixed that issue. Please check my code and merge it if it look okay.

theonlynick0430 commented 6 years ago

Thanks for this fix. We highly appreciate it. The changes have been officially merged.

On Mon, Aug 6, 2018 at 1:43 PM, Deokhyun Ko notifications@github.com wrote:

When I called removeAllObservers() and/or removeObserver(withHandle: GFSQueryHandle) on GFSQuery, It fall into infinite loop on reset() function. When for loop started, query variable keep getting nil and never exit from loop. So, I fixed that issue. Please check my code and merge it if it look okay.

You can view, comment on, or merge this pull request online at:

https://github.com/imperiumlabs/Geofirestore-ios/pull/3 Commit Summary

  • Fix infinite loop

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/imperiumlabs/Geofirestore-ios/pull/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AaSzNp9tzY2Bn0Fe3O-HcAIz5ifFPwk4ks5uOKpygaJpZM4VxDfa .

mainto commented 6 years ago

Thanks!