Macro solving errors are not handled properly

impero-com / typebinder

Exports TS definitions from Rust module

Other

20 stars 2 forks source link

Macro solving errors are not handled properly #18

Closed AlisCode closed 3 years ago

AlisCode commented 3 years ago

If a macro solver doesn't solve properly, the process doesn't generate the file without printing an error.

Macro solving should be handled the same way as type solving.

greyblake commented 3 years ago

Address in the main code base by adjusting a custom macro solver. Closing the issue.

AlisCode commented 3 years ago

It seems there was a misunderstanding when this issue was first filed, the error is displayed indeed. The typebinder process (CLI) should probably be killed when such an error occurs. I'm reopening this issue in order to address this someday

AlisCode commented 3 years ago

Closing the issue now, this was indeed a bug in our integration codebase