search

imperodesign / generator-impero

Impero's website skeleton generator, courtesy of Yeoman
Other
1 stars 1 forks source link

.replace() may not be functioning correctly #61

Closed samhh closed 7 years ago

samhh commented 7 years ago

As it was coded with a string and not regex, it will only replace one instance of the found double quotes. Fix by using regex.

A real WTF JavaScript moment there.

https://github.com/imperodesign/generator-impero/blob/master/generators/app/templates/package.json#L4

samhh commented 7 years ago

https://github.com/imperodesign/generator-impero/commit/e58c2dd82bef483267a1642d87101d0933fa00ec