search

impersonator-eth / impersonator

Login into dapps by impersonating any Ethereum address via WalletConnect or iFrame!
https://impersonator.xyz
261 stars 47 forks source link

[String Update] Rename "Approve" to "Connect" #3

Closed jrfrantz closed 2 years ago

jrfrantz commented 2 years ago

Approve sort of suggests you're about to make a transaction (eg approve a smart contract to operate your ERC721/ERC20). But really the action is just connecting the impersonating account to a website. So I'm proposing renaming it to Connect since that's consistent with how other wallet apps (eg metamask, rainbow) handle this part.

FYI hope it's not weird that I'm making two of these in-a-row out of nowhere :). I don't expect to have any more. I'm doing this because I appreciate your project, because I want to contribute to open source projects, and because I'm hoping I can leverage impersonator to make the user experience for my smart contract + web app, Flashmint cleaner. Cheers

vercel[bot] commented 2 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @apoorvlathey on Vercel.

@apoorvlathey first needs to authorize it.

apoorvlathey commented 2 years ago

You are right, that makes sense.

Haha not weird, thanks for contributing!