imperugo / StackExchange.Redis.Extensions

MIT License
601 stars 179 forks source link

Upgraded to 9.0, now receiving warning: "Package 'StackExchange.Redis.Extensions.Core 9.0.0' was restored using '.NETFramework,Version=v4.6.1...' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project." #552

Closed lorenh closed 1 year ago

lorenh commented 1 year ago

Describe the bug After upgrading to 9.0, now receiving build warning: "Package 'StackExchange.Redis.Extensions.Core 9.0.0' was restored using '.NETFramework,Version=v4.6.1...' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project."

To Reproduce Simply upgrading my project to StackExchange.Redis.Extensions.Core 9.0.0 from 8.0.5 seems to have caused this.

Expected behavior I did not expect to receive a build warning.

Desktop:

lorenh commented 1 year ago

(I should add, that despite the build warning, everything still seems to be working)

imperugo commented 1 year ago

Hi @lorenh Thanks for the feedback. I think the reason is related that I've removed the netstandard 2.0 in favour to 2.1.

I tried to maintain the 2.0 but din't find a right way with the pipeline. What is the target framework of your project?

lorenh commented 1 year ago

I'm targeting net6.0 in this particular service, but we still have a hard-to-migrate full-framework monolith and try very hard to target netstandard2.0 to allow things to be shared between framework and dotnet core. Once we go netstandard2.1 I understand we can no longer do that. In this case I can't see this project ever needing to be shared back to the full framework system so I can just switch to netstandard2.1 (or even net6.0 for that matter).

Thanks, your answer confirmed my suspicion that support for netstandard2.0 is gone. We'll make do. Thanks for your excellent work on this very useful project.

imperugo commented 1 year ago

thanks @lorenh I will do some more testing to see if I can support 2.0 as well.

Thanks again