search

imperva / automatic-api-attack-tool

Imperva's customizable API attack tool takes an API specification as an input, generates and runs attacks that are based on it as an output.
MIT License
451 stars 91 forks source link

[INTERNAL] - Update gradle version to be compatible with Java 17 and … #11

Open isidro-ruiz opened 1 year ago

isidro-ruiz commented 1 year ago

…fix for NullPointerException

isidro-ruiz commented 1 year ago

Hi yes. In Windows these marks give exceptions as those ASCII chars are not compatible and only work for Linux....

El vie, 4 nov 2022 23:14, Boris Serebro @.***> escribió:

@.**** commented on this pull request.

In src/main/java/com/imperva/apiattacktool/tests/MainTest.java https://github.com/imperva/automatic-api-attack-tool/pull/11#discussion_r1014497515 :

         TestReporter.log("");
         Assert.fail(anyException.getMessage());

         return;

     }

     int statusCode = httpResponse.getStatusLine().getStatusCode();

     boolean isStatusCodeValid = httpResponseValidator.isValidHttpCode(statusCode);

  • TestReporter.log((isStatusCodeValid? "✅ " : "❌ ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)"));

  • TestReporter.log((isStatusCodeValid? "ok " : "not ok ") +"Request was: " + httpRequest.toString() + ", Response status code: " + statusCode + (isStatusCodeValid? " " : " (UNEXPECTED)"));

Thanks for the change. Do the visual marks create any issues? Their intention was only to help see whether there were issues visually. I suggest having both the text and the visual marks.

— Reply to this email directly, view it on GitHub https://github.com/imperva/automatic-api-attack-tool/pull/11#pullrequestreview-1169234900, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYM4G5DS2ANVH4KFNODFNLWGWDDLANCNFSM6AAAAAARV7LUBE . You are receiving this because you authored the thread.Message ID: @.***>

thenorthernpole commented 1 year ago

Thanks! Is there a visual character we can use which will work for both?

Thanks!

isidro-ruiz commented 1 year ago

No problema. I Guess you can use the Unicode one of this versión, ir should work for both: https://en.wikipedia.org/wiki/Check_mark#Unicode

Other important changes un that pull request are the upgrade of gradle version in order to support jdk17 and the check for an scenario coming with empty values and trowing an excepcion

El vie, 4 nov 2022 23:51, Boris Serebro @.***> escribió:

Thanks! Is there a visual character we can use which will work for both?

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/imperva/automatic-api-attack-tool/pull/11#issuecomment-1304319449, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYM4GYCEJRAQBF5MFDUHGDWGWHPDANCNFSM6AAAAAARV7LUBE . You are receiving this because you authored the thread.Message ID: @.***>

thenorthernpole commented 1 year ago

Thanks! Would appreciate it if you could incorporate such a character that is compatible with your WIndows machine, and I will approve.

Thanks!

isidro-ruiz commented 1 year ago

Ok thank u!

El sáb, 5 nov 2022 23:04, Boris Serebro @.***> escribió:

Thanks! Would appreciate it if you could incorporate such a character that is compatible with your WIndows machine, and I will approve.

Thanks!

— Reply to this email directly, view it on GitHub https://github.com/imperva/automatic-api-attack-tool/pull/11#issuecomment-1304650030, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALYM4GZGCBKR6VWAO4LBFGTWG3KVHANCNFSM6AAAAAARV7LUBE . You are receiving this because you authored the thread.Message ID: @.***>

thenorthernpole commented 1 year ago

Hey @isidro-ruiz , are you planning on making the changes?

Thanks!