imperva / terraform-provider-incapsula

This package is a plugin for Terraform, and is designed to be used to auto-provision sites in Incapsula via Incapsula’s API from the terraform cli/yaml configurations.
Mozilla Public License 2.0
44 stars 72 forks source link

is_standby flag on data centers is broken #41

Closed oskarm93 closed 4 years ago

oskarm93 commented 4 years ago

After recent call with Imperva support, it turns out that is_standby flag on data centers resource is not being correctly populated.

https://www.terraform.io/docs/providers/incapsula/r/data_center.html#is_standby

This is because list data centers and add data centers API calls (used to set this flag) do not retrieve correct values. This leads to undefined behaviour when your resources have this flag defined, as we saw with many of our data centers turn to standby overnight. Only edit API call is able to set the standby flag correctly.

We want to continue using the provider, but cannot chance another outage due to undefined behaviour, so I propose to remove the flag until it's production ready.

anandkunal commented 4 years ago

HI @xenalite - I removed this functionality last week after our meeting. The change showed up in this commit - https://github.com/imperva/terraform-provider-incapsula/commit/56633b5afdbac675beecda4e01a08f5c2cc45245

Going to go ahead and close this issue out.