search

imperva / terraform-provider-incapsula

This package is a plugin for Terraform, and is designed to be used to auto-provision sites in Incapsula via Incapsula’s API from the terraform cli/yaml configurations.
Mozilla Public License 2.0
44 stars 72 forks source link

Add a parameter to enable API discovery. #438

Open uduncanu opened 4 months ago

uduncanu commented 4 months ago

We're trying to set up many sites entirely via Terraform, and noticed while trying to set one up with APIs that there wasn't a way to actually enable API discovery without a different manual step, so I've tried to add in that functionality here.

avikivanda commented 3 months ago

Now this API is not supported for enabling a API discovery. Enabling discovery is deprecated from this API. So this change is not relevant.

warmfusion commented 2 months ago

@avikivanda can you provide references to the deprecation notices and propose an alternative approach for us to take here?

avikivanda commented 2 months ago

@warmfusion Reference to API security spec : https://docs.imperva.com/bundle/advanced-api-security/page/83093.htm Use POST /v2/discovery/sites/settings to update multiple sites at once.

warmfusion commented 2 months ago

Thanks @avikivanda, strange that the api documentation requires a login to view.

Do you know when Imperva might support these updated API settings in the imperva/terraform-provider-incapsula project, or are you assuming we'd provide a pull request for this behaviour?