data-secret.text is not common but provider specific.

impfen / apps-inoeg

Kiebitz Web Applications (for users, providers and mediators). Still a work-in-progress, use with care!

https://kiebitz.eu/

GNU Affero General Public License v3.0

0 stars 5 forks source link

data-secret.text is not common but provider specific. #41

Closed topialla closed 2 years ago

topialla commented 2 years ago

changed structure in po-file. We will see, if weblate ist intelligent enough ;-)

The PR is based on this branch here> https://github.com/kiebitz-oss/apps-inoeg/pull/40

render[bot] commented 2 years ago

Your Render PR Server URL is https://kiebitz-user-pr-41.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7f23cnh8vl0ij0bovug.

benbender commented 2 years ago

@topialla even if weblate is smart enough, lingui-js will overwrite those changes next time it extracts "its" translations from the templates. The correct place to change the placeholder would be https://github.com/kiebitz-oss/apps-inoeg/blob/10071dcbcf2d6d60c7601ee989d3ce63b78bc37d/apps/provider/src/pages/onboarding/DataSecret.tsx#L12

topialla commented 2 years ago

I thought I also changed it there? But as before: No worries @benbender this is why you do stuff and not I ;-) Was not a lot of work, and I learned some things.