search

impierce / identity-wallet

A Tauri-based Identity Wallet for people to manage Decentralized Identities and Verifiable Credentials.
https://www.impierce.com
Apache License 2.0
17 stars 4 forks source link

ci: add `svelte-check` #184

Open daniel-mader opened 2 months ago

daniel-mader commented 2 months ago

Description

  1. Add Check step to CI pipeline (.github/workflows/format-lint-test.yaml) after Lint step:
- name: Check
  working-directory: ./unime
  run: npm run check
  1. Iterate through all // eslint-disable-next-line and resolve or add comment why they should be kept

Motivation

Enhance code quality

Requirements

n/a

Open Questions

n/a

Are you planning to contribute this in a PR?

Yes

maiertech commented 1 month ago

There are currently 55 48 type issues that need to be resolved before svelte-checked can be turned on in CI.

maiertech commented 17 hours ago

TS errors in prompt/share-credentials/+page.svelte can be fixed in the same way as in prompt/accept-connection/+page.svelte.