I removed the checkboxes from the radio button elements. When not disabled, a checkbox within the selected theme could be unchecked. When disabled, the checkbox created a blind spot, which could not be clicked to select a theme. The border in primary color gives sufficient feedback of which theme is selected.
Links to any relevant issues
229
How the change has been tested
Manual testing. The radio group is part of the tab sequence and while focused you can use the up and down keys to change selection.
Definition of Done checklist
Add an x to the boxes that are relevant to your changes.
[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Description of change
I upgraded
ThemeSelectto be a Melt UI radio group with keyboard support.I removed the checkboxes from the radio button elements. When not disabled, a checkbox within the selected theme could be unchecked. When disabled, the checkbox created a blind spot, which could not be clicked to select a theme. The border in primary color gives sufficient feedback of which theme is selected.
Links to any relevant issues
229
How the change has been tested
Manual testing. The radio group is part of the tab sequence and while focused you can use the up and down keys to change selection.
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.