search

impierce / identity-wallet

A Tauri-based Identity Wallet for people to manage Decentralized Identities and Verifiable Credentials.
https://www.impierce.com
Apache License 2.0
26 stars 3 forks source link

`Unable to parse QR code` error hangs #334

Open Oran-Dan opened 3 months ago

Oran-Dan commented 3 months ago

Description

After scanning a qr code which fails, all subsequent scans display the same error with the qrcode text from the original error. So the error message stays the same even though the qr code has changed to one which would otherwise always work, if it hadnt been for the error prior to that.

Sometimes it seems to escape this loop, but especially on a fresh profile with the first scan being a failed one, the error seems to hang indefinitely.

Hardware Specification

Operating system:iOS RAM: Cores: Device: iphone

Steps to Reproduce the Bug

  1. scan https://selv.iota.org/en/government/prove and you will get an error.
  2. the scan either https://selv.iota.org/en/company/prove or any qr from the ngdil demo https://demo.ngdil.com/demo/choose-journey
  3. Error persists
  4. (try step 2 with a fresh profile, skipping step 1, and everything should work fine)

Actual Behaviour

error hangs

Expected Behaviour

error doesnt hang and every new scan should work fine after the first failed.

Errors

error: failed to parse QR code

nanderstabel commented 3 months ago

I have indeed the same issue when I follow your steps to reproduce.Interestingly I don't have a problem when between step 1. and 2. I close the error message. Is that the same for you?

Oran-Dan commented 3 months ago

you're right, its the same for me.

Oran-Dan commented 3 months ago

anyway error messages should dissappear after an x amount of time i think. Furthermore, some are truncated without the option to read the full thing also degrading the UX a bit i think. Even though in dev mode we can see the whole message in the debug messages tab, I think it's still a bit off to display partial error messages to the user without enabling them to read the whole thing. They can never know what more is after the ... Or we have to keep all non dev error messages short

daniel-mader commented 3 months ago

Errors disappear automatically in "regular mode" (non-dev). I agree they shouldn't be truncated in dev mode, but in regular mode the user usually does not care about any technical details. Just if it was their fault or some technical error. We need to improve the error experience, no doubt. @Oran-Dan It could make sense to also provoke errors in regular mode (dev mode disabled) to complete the picture and collect more UX feedback. 👍