impierce / identity-wallet

A Tauri-based Identity Wallet for people to manage Decentralized Identities and Verifiable Credentials.
https://www.impierce.com
Apache License 2.0
26 stars 3 forks source link

feat: display `alignment` & `criteria` for Open Badges 3.0 #386

Closed Oran-Dan closed 3 weeks ago

Oran-Dan commented 1 month ago

Description of change

I've added the alignment field in Openbadge to the fields which are displayed in the Badge Overview.

The serde_json dependency updated from 1.0.20 to 1.0.28. This created a flaky error message being returned in the fn validate_domain_linkage (meaning it wasn't consistent between different runs and different environments). To counter this we have made static error messages which are more explicit.

Links to any relevant issues

How the change has been tested

Ran program and checked visually. Existing tests pass.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

Oran-Dan commented 3 weeks ago

For you next frontend PR, please add some hints for reviewers on how to test the UI changes. In this case I can't fire up my local UniCore because it does not have the credential config I need to test. I figured it out, but the easier you make it for me the faster I review :)

You're right, duely noted