added external_signer method and corresponding Trait which allows implementers to use an external signing method like Stronghold to sign messages.
Loosened validation rules for decoding jwts: oid4vc-core/src/jwt.rs. jsonwebtoken crate requires exp by default but this is not required in oid4vc.
token_endpoint and authorization_endpoint in AuthorizationServerMetadata have been made optional.
implemented impl FormatExtension for (). This simply means that CredentialFormats<()> can be used without a credential or optional parameters
Added ResponseType::VpToken
Loosened deserialization rules for RequestUrl so that unknown fields simply will be ignored.
Links to any relevant issues
Because of the loosening of deserialization, there is currently one unit test that fails:
This test is currently failing because the serialization rules for RequestUrl have been loosened. This
will be addressed in #19 .
How the change has been tested
All unit tests still succeed with the exception of the one mentioned above
Definition of Done checklist
Add an x to the boxes that are relevant to your changes.
[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] New and existing unit tests pass locally with my changes
Description of change
Various changes:
external_signermethod and corresponding Trait which allows implementers to use an external signing method like Stronghold to sign messages.oid4vc-core/src/jwt.rs.jsonwebtokencrate requiresexpby default but this is not required in oid4vc.token_endpointandauthorization_endpointinAuthorizationServerMetadatahave been made optional.impl FormatExtension for (). This simply means thatCredentialFormats<()>can be used without a credential or optional parametersResponseType::VpTokenRequestUrlso that unknown fields simply will be ignored.Links to any relevant issues
Because of the loosening of deserialization, there is currently one unit test that fails: This test is currently failing because the serialization rules for RequestUrl have been loosened. This will be addressed in #19 .
How the change has been tested
All unit tests still succeed with the exception of the one mentioned above
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] New and existing unit tests pass locally with my changes