implydata / pivot

An interactive data exploration UI for Druid
https://docs.imply.io/latest/pivot-overview/
646 stars 40 forks source link

Filter Search functionality broken for dimensions with Lookups #119

Closed peter-triplelift closed 8 years ago

peter-triplelift commented 8 years ago

When searching, the list disappears after a brief moment. Video: http://screenshot.3lift.com/0s2p0G1U1n2n

vogievetsky commented 8 years ago

What version of Pivot are you using? (What does it say on the browser tab?)

peter-triplelift commented 8 years ago

0.7.28

On Mar 9, 2016, at 9:26 PM, Vadim Ogievetsky notifications@github.com wrote:

What version of Pivot are you using? (What does it say on the browser tab?)

— Reply to this email directly or view it on GitHub.

vogievetsky commented 8 years ago

I can not repro on latest or on 0.7.28. I need some more information:

  1. Does this happen on latest Pivot (0.7.35) also?
  2. Can you repro on other dimensions or only on Publisher?
  3. How large is the publisher dimension? < 101 or 100 >= distinct values?
peter-triplelift commented 8 years ago
  1. Yes, it happens on Pivot 0.7.35 as well.
  2. It's reproducible on other dimensions (typically large dimensions).
  3. The publisher dimension is around 3500 values.

It seems to only be happening on dimensions with lookups. I have Tactic_Id as well as Tactic_Name as possible dimensions, and Tactic_Id is correctly searching, while Tactic_Name is not. There's also another dimension with a lookup that has < 100 distinct values, and that is also searching correctly

Thanks!

peter-triplelift commented 8 years ago

Quick update: I changed the date range so that dimension with <100 values had >100 values. The search functionality no longer worked. Hope this helps, and thanks for the quick responses!

vogievetsky commented 8 years ago

Lookups you say... ok I have not tested it yet but I bet that is where the problem lies.

vogievetsky commented 8 years ago

Yep it's the lookups that spoil it, can confirm. Plywood can not evaluate $tactic_Id.lookup(your_lookup_name).contains('wiki') in Druid.

Good news: there is a new Druid feature that will allow this to work that I have asked for presciently. Bad news: this fix is part of the Druid 0.9.0 milestone

I will make this work with Plywood (ETA: 1 week) but it will only work for people who are running Druid 0.9.0 or better. So you will probably need to upgrade your Druid as well as your Pivot for this to work.

People using lookup with Druid <= 0.8.3 will have to live with broken search forever. I will add an error message to that menu though.

vogievetsky commented 8 years ago

Just to be clear: at the time of this comment Druid 0.9.0 has not been released yet.

peter-triplelift commented 8 years ago

Thanks for the info, Vadim! Do you know an approximate timeline for when Druid 0.9.0 will be released?

vogievetsky commented 8 years ago

According to @gianm, who is sitting next to me: "There is no official timeline, but ether end of next week or the week after. Probably the week after"

peter-triplelift commented 8 years ago

That works, thanks!

vogievetsky commented 8 years ago

I would rather keep the issue opened until the Pivot side of the fix is shipped.

vogievetsky commented 8 years ago

Alright so latest pivot (0.7.41) will present you with a nice error message feedback now. Once you upgrade to druid 0.9.0 it will magically start working (and be faster in many ways as well). I tried it with 0.9.0_rc3: works like a charm.

peter-triplelift commented 8 years ago

Awesome, Vadim. Thanks so much!

vogievetsky commented 8 years ago

Wooooo Druid 0.9.0 is out finally. (for anyone following this thread) If you are using Pivot I strongly advice upgrading to 0.9.0 there are a TON of improvements in the Pivot <-> Druid communication.

peter-triplelift commented 8 years ago

Awesome, thanks for the update! The search functionality works perfectly now.