search

implydata / plywood-druid-requester

Druid requester for Plywood (within node)
Apache License 2.0
25 stars 14 forks source link

request has been deprecated #13

Open themaric opened 4 years ago

themaric commented 4 years ago

Hi guys,

According to https://github.com/request/request/issues/3142 the package has been deprecated.

We might want to see what to do with it otherwise there will be many warnings during yarn upgrade:

warning plywood-druid-requester > request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142

The worst thing that could happen is that request stops working in the future due to stale code base.

Thanks!

themaric commented 10 months ago

Just FYI, once upgraded to v3.0.0 a deprecation warning from the description disappeared, but now getting the following:

warning plywood-druid-requester > @implydata/request > uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
warning plywood-druid-requester > @implydata/request > har-validator@5.1.5: this library is no longer supported