import-js / eslint-import-resolver-typescript

This plugin adds `TypeScript` support to `eslint-plugin-import`
https://www.npmjs.com/package/eslint-import-resolver-typescript
ISC License
714 stars 62 forks source link

[import/no-unresolved] when importing from another package in a monorepo #210

Open tpluscode opened 1 year ago

tpluscode commented 1 year ago

Specifically, I have a package with an export map like this

{
  "name": "@hydrofoil/roadshow-ng",
  "exports": {
    ".": "./index.js",
    "./rs-view.js": "./rs-view.js",
    "./viewers.js": "./viewers.js"
  }
}

In other packages I import '@hydrofoil/roadshow-ng/rs-view.js' etc. This gets reported as unresolved.

Interestingly, if I drop the extension or change to .ts, the import plugin no longer complains...

tpluscode commented 1 year ago

Anyone?

simondean commented 1 year ago

Hi. This fixed a similar issue for me. I didn't need to add a exports entry to my package.json files though.

I fixed my issue by adding this to my eslint.cjs file in the root of my monorepo:

    parserOptions: {
        project: ['tsconfig.json', 'packages/*/tsconfig.json'],
        node: true,
    },
    settings: {
        'import/parsers': {
            '@typescript-eslint/parser': ['.ts'],
        },
        'import/resolver': {
            typescript: {
                // See https://github.com/import-js/eslint-import-resolver-typescript for documentation of these settings
                // This `project` entry is needed, in addition to the `project` entry above under `parserOptions`,
                // otherwise eslint-plugin-import's `import/no-unused-modules` rule will not work correctly
                project: ['tsconfig.json', 'packages/*/tsconfig.json'],
            },
        },
    },
JounQin commented 10 months ago

@tpluscode Sorry I'm very late here, can you please provide an online runnable reproduction?

tpluscode commented 10 months ago

@JounQin: https://github.com/tminuscode/resolver-typescript-package-exports

tpluscode commented 6 months ago

Have you had a chance to to look into it @JounQin \

JounQin commented 6 months ago

See #275 and https://github.com/webpack/enhanced-resolve/issues/413