Open ignatiusreza opened 4 years ago
Could you clarify: why do really old node versions need to be able to resolve exports
though? Or is there some other use case I'm missing?
The use cases for resolve are far more plentiful than for eslint. resolve needs to resolve, in any node version, a path as if it would be resolved in any other node version. A pre-exports node may want to emulate “exports”. A post-exports node may want to emulate pre-exports. A modern node may simply want to know what a pre-exports node user would see.
I think the sane solution here is to don't worry at all about any unmaintained Node.js version, it's said, don't provide support for anything older than Node.js v18.
I really don't buy that the only way to have good compatibility is if there is a single implementation of the algorithm. Tons of projects are already using enhanced-resolve
anyway, and putting a new implementation out in ESLint will be an amazing way to safely get feedback on whether there is behavioral parity.
@piranna ”sane” isn’t an appropriate word to be using in this context; and almost all of my packages support down to node 0.4, and will continue to do so for the foreseeable future. Platform support has no correlation to what a package should support.
@conartist6 thats fine, your agreement isn’t required.
I think this is great because now we're unblocked. It's clear from this conversation that my beliefs about the problem are different enough from yours that I should build a new package, and that it will be clearly differentiated in the marketplace.
Everyone who just wants to use the new stuff can stop bugging you, which is a win for you as well.
Go for it. As you said tho, there’s already packages that do this, so i don’t think there’s much value in yet another one; the value is in resolve itself doing it.
I would agree that all that was off-topic if this were a conversation on the resolve
package, but as this is eslint-plugin-import
parts of that conversation seem quite relevant.
To recap the now-hidden conversation:
resolve
package>= 0.4.0
, meaning he can only work in es3>= 4.0.0
for the last six years (at least), and can use es6resolve
favors speed and compatibility over readability and correctnessI believe that in sum this means that eslint-plugin-import
should seek out a resolve implementation which is better aligned with its needs and the needs of its users.
It won’t; using resolve - the most common implementation - is what is most aligned with it and its users needs.
Again, your agreement isn’t required, and to be clear, is also irrelevant.
I would appreciate if you would allow my condensed argument to stand as a matter of public record. Please?
Your summary would be fine; your conclusion would only distract.
The comment may be deleted now, but I'm still calling it out. That was rude and inappropriate. We can compete with and disagree with other people and still respect them.
@conartist6 no comments were deleted afaict, so I’m not sure what you’re referring to.
Not deleted by you then, but it was emailed to anyone who subscribes to this thread.
ah, yes, i found it in my email :-) some people have nothing better to do, i guess.
I feel that you have abused your position as a moderator to protect your image in the face of reasoned dissent, so I can't say I'm that thrilled with you at the moment.
Is there an ombudsman or another moderator who could assist in untangling this?
I'm not wedded to any particular outcome, but it's unacceptable to me that all discussion on the topic should be summarily silenced.
It’s just me, and what’s acceptable is only up to collaborators. I’m going to lock the thread for a bit.
Additionally, hiding comments isn’t silencing anything - that’d be called “deleting comments”. I’m just making them hidden by default so they don’t distract new readers of the issue.
From this announcement
Might need to be fix in
resolve
package..