search

import-js / eslint-plugin-import

ESLint plugin with rules that help validate proper imports.
MIT License
5.57k stars 1.57k forks source link

webpack resolver: Simplify loop #3029

Closed fregante closed 2 months ago

fregante commented 4 months ago

This PR reduces the amount of code run by using a plain for loop with early return. I was hesitant to make the change at first but I noticed that there are a lot of similar loops in the code so it shouldn't be a problem to use the same here

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 95.91%. Comparing base (bdff75d) to head (db8b95d). Report is 2 commits behind head on main.

Files Patch % Lines
resolvers/webpack/index.js 37.50% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3029 +/- ## =========================================== + Coverage 85.33% 95.91% +10.57% =========================================== Files 78 78 Lines 3300 3302 +2 Branches 1160 1162 +2 =========================================== + Hits 2816 3167 +351 + Misses 484 135 -349 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

socket-security[bot] commented 3 months ago

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request