search

import-js / eslint-plugin-import

ESLint plugin with rules that help validate proper imports.
MIT License
5.57k stars 1.57k forks source link

[Test] actually push `namespace` case into `valid` array #3046

Closed G-Rath closed 2 months ago

G-Rath commented 2 months ago

I came across this while working on #2996 - I'm pretty sure it's not intentional 😅

To make it a bit easier to spot, I've also put the closing ) on a newline for both the valid and invalid arrays, even though that's not technically required to fix the test itself.

I've also checked the rest of the codebase and found no other instances of comma expressions being "used".

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.13%. Comparing base (8bdb32b) to head (a3015eb). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3046 +/- ## ========================================== - Coverage 95.30% 95.13% -0.18% ========================================== Files 81 81 Lines 3411 3411 Branches 1195 1195 ========================================== - Hits 3251 3245 -6 - Misses 160 166 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.