[utils] [fix] `parse`: remove unneeded extra backticks

G-Rath commented 2 months ago

I won't admit how many times I'd read this warning while working on #2996 before I realised there were these (cosmetic) double backticks 😅

ljharb commented 2 months ago

They're intentional, to demarcate a JS property path versus prose words.

G-Rath commented 2 months ago

ah ok - that doesn't entirely surprise me, but is that a typical thing? I don't think I've ever seen double backquotes used, and meanwhile the sentence starts with a single backquote of a property which is why I decided to open the PR.

Either way no biggie, feel free to close if you want to keep it as is 🙂

ljharb commented 2 months ago

ohhh i get it, no, this is indeed just a typo :-) thanks, good catch

G-Rath commented 2 months ago

sorry I should have included an actual snippet or screenshot 😅

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.26%. Comparing base (95849c8) to head (da626ea).

Files with missing lines	Patch %	Lines
utils/parse.js	0.00%	1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (95849c8) and HEAD (da626ea). Click for more details.

HEAD has 60 uploads less than BASE
| Flag | BASE (95849c8) | HEAD (da626ea) | |------|------|------| ||61|1|

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3057 +/- ## =========================================== - Coverage 95.46% 85.26% -10.21% =========================================== Files 82 82 Lines 3549 3549 Branches 1244 1244 =========================================== - Hits 3388 3026 -362 - Misses 161 523 +362 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

import-js / eslint-plugin-import

[utils] [fix] `parse`: remove unneeded extra backticks #3057

Codecov Report