search

import-js / eslint-plugin-import

ESLint plugin with rules that help validate proper imports.
MIT License
5.57k stars 1.57k forks source link

[New] add TypeScript types #3097

Open G-Rath opened 2 weeks ago

G-Rath commented 2 weeks ago

For now I've just typed these out manually based on what we're using internally - while it would be good to have some tests at some point, I'm hoping/recommending not blocking on that for now as I think the types are small enough to be easy to maintain manually for the time being.

Resolves #3090

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.58%. Comparing base (a20d843) to head (5fc6cd3).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3097 +/- ## ========================================== - Coverage 95.28% 94.58% -0.70% ========================================== Files 83 83 Lines 3584 3584 Branches 1252 1252 ========================================== - Hits 3415 3390 -25 - Misses 169 194 +25 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

ljharb commented 2 weeks ago

Can we add a tsc run, at least?

G-Rath commented 1 week ago

Can we add a tsc run, at least?

Done - note that it requires using typescript v5 since types like @types/node require that version, which led to a weird "works locally but not in CI", but I think I've got that resolved and should be good enough for now 🤞

socket-security[bot] commented 1 week ago

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request