importantimport / hatsu

🩵 Self-hosted & Fully-automated ActivityPub Bridge for Static Sites.
https://hatsu.cli.rs
GNU Affero General Public License v3.0
107 stars 2 forks source link

fix(apub): set note visibility to public #30

Closed reesericci closed 1 month ago

reesericci commented 1 month ago

I think that the default behavior, unlisted posts, is counter-intuitive and should instead be public posts by default.

Ideally, this should be configurable through an option on the individual post or the feed level (that's why I'm leaving this as a draft).

I was thinking I could add it to the existing extension on the JSON Feed, and then work on making an XML namespace to hold options for RSS/Atom.

I'm not sure whether this would require a database schema change, if someone could chime in here that would be great.

kwaa commented 1 month ago

Hatsu's posts should be public by default and cannot be changed, Looks like I got to and cc wrong.

and then work on making an XML namespace to hold options for RSS/Atom.

Since Hatsu uses the feed-rs library to parse Atom / RSS, I don't think the extension features can be used.

reesericci commented 1 month ago

If this is a bug do we want to get this merged?

kwaa commented 1 month ago

Kind of strange that Mastodon is also using cc Public.

https://github.com/LemmyNet/lemmy/blob/main/crates/apub/assets/mastodon/objects/note.json#L21-L25

I thought Hatsu generated posts were supposed to be public.

reesericci commented 1 month ago

This is documented here: https://docs.joinmastodon.org/spec/activitypub/#Mention

kwaa commented 1 month ago

Ah, I see. Thanks for the Contribution!