importantimport / hatsu

🩵 Self-hosted & Fully-automated ActivityPub Bridge for Static Sites.
https://hatsu.cli.rs
GNU Affero General Public License v3.0
130 stars 2 forks source link

Set icon #33

Closed reesericci closed 4 months ago

reesericci commented 4 months ago

Is it possible to set the icon of the fedi actor or pull it from the RSS feed?

image

kwaa commented 4 months ago

Hatsu currently gets the icon from the feed. Atom / RSS should also work, but I'm not sure how feed-rs are handled.

https://github.com/importantimport/hatsu/blob/1dc88b73db9a38a970238f445d455f87d5099bd9/crates/feed/src/user_feed.rs#L107

reesericci commented 4 months ago

Is it possible that it's because I use an SVG icon?

kwaa commented 4 months ago

Is it possible that it's because I use an SVG icon?

Hatsu only verifies that it is a url, not the icon format. For reference, you can try accessing your actor json to see if it contains the icon

reesericci commented 4 months ago

Nope I don't see anything: https://fedi.place.reeseric.ci/users/place.reeseric.ci

kwaa commented 4 months ago

Nope I don't see anything: fedi.place.reeseric.ci/users/place.reeseric.ci

I found the reason, RSS2 doesn't have an icon. maybe I should use the logo as a fallback.

https://github.com/feed-rs/feed-rs/blob/0f4d13488952b0d9f0abd140caeb30be922fcac8/feed-rs/src/parser/rss2/mod.rs#L65

reesericci commented 4 months ago

So I just pulled the latest version from main and still getting nothing

kwaa commented 4 months ago

So I just pulled the latest version from main and still getting nothing

This is weird, I'll update the unit test.

kwaa commented 4 months ago

So I just pulled the latest version from main and still getting nothing

It looks like the reason is that full_update is not updating the user info, this feature will be added later.

kwaa commented 4 months ago

It looks like the reason is that full_update is not updating the user info, this feature will be added later.

This should be fixed by #37, but I think this part of the code is poorly written.