impossibl / pgjdbc-ng

A new JDBC driver for PostgreSQL aimed at supporting the advanced features of JDBC and Postgres
https://impossibl.github.io/pgjdbc-ng
Other
596 stars 108 forks source link

Suggested fix for #551 #561

Open tlf30 opened 2 years ago

tlf30 commented 2 years ago

This is a suggested fix for #551. I created a new type to handle the text array, and modified the generator to use this new type when the DB has a TEXT[] in the UDT.

Please let me know what you think of this change, and test it thoroughly. I tested it on my dev system, but it would be good to make sure that this change does not have wider impacts. My dev work was done in Windows, which this repo's build script does not support. I had to test on an internal fork with a build script that does work in windows, then copy the changes over into this branch. Please run tests and ensure everything works as expected, and verify that this indeed does fix the issue for you as well. I tested with my test repo for this issue: https://github.com/tlf30/pgjdbc-ng-test5.

It may be beneficial to add the datatypes for other arrays as well, as this issue may arise with more than just the TEXT datatype.

If this change is not to your liking, please close this PR.