search

impossibl / pgjdbc-ng

A new JDBC driver for PostgreSQL aimed at supporting the advanced features of JDBC and Postgres
https://impossibl.github.io/pgjdbc-ng
Other
596 stars 108 forks source link

Fixes issue #562, multiple calls to PGBuffersArray.free() produces NullPointerException #563

Open JTEgan opened 2 years ago

JTEgan commented 2 years ago

API doc for java.sql.Array says that when multiple calls are made to free(), successive calls should be a no-op. This change makes the PGBuffersArray class adhere to that spec.

kdubb commented 2 years ago

@JTEgan Thanks for the contribution. Can you add a test cast in ArrayTest to verify this?

JTEgan commented 2 years ago

Yep, will do

On Thu, Sep 16, 2021, 11:20 PM Kevin Wooten @.***> wrote:

@JTEgan https://github.com/JTEgan Thanks for the contribution. Can you add a test cast in ArrayTest to verify this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/impossibl/pgjdbc-ng/pull/563#issuecomment-921424750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFABZQA5TF5KL44TYAW2JL3UCKXYHANCNFSM5EFUZYCA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kdubb commented 8 months ago

@JTEgan Please push a new (or empty) commit to restart actions.

JTEgan commented 8 months ago

yeah geez it's been 2 years, I gotta get around to writing that test ;-)

What does it mean to restart actions?

kdubb commented 8 months ago

The action storage has expired. So I don't know the outcome of them. A new commit (even if just empty) will re-run them.