search

impossibl / pgjdbc-ng

A new JDBC driver for PostgreSQL aimed at supporting the advanced features of JDBC and Postgres
https://impossibl.github.io/pgjdbc-ng
Other
596 stars 108 forks source link

Update test certs to use rsa:2048 #601

Closed davidwheeler123 closed 1 month ago

davidwheeler123 commented 1 month ago

As per https://github.com/impossibl/pgjdbc-ng/pull/578#issuecomment-2141050874 the tests are failing with an error 

"/var/lib/postgresql/server.crt": ee key too small

According to this stack overflow response the solution to this is to increase key size to 2048. That's what this PR does

davidwheeler123 commented 1 month ago

Tests have passed 😄

davidwheeler123 commented 1 month ago

Looks like I don't have permission to merge though

kdubb commented 1 month ago

👍

kdubb commented 1 month ago

Permissions should be fixed

davidwheeler123 commented 1 month ago

Thanks, merged. There's another issue, couldn't deploy docs. I'll have a look when I can.

davidwheeler123 commented 1 month ago

BTW do you like to delete the branches once PR is merged to clean up?

davecramer commented 1 month ago

BTW do you like to delete the branches once PR is merged to clean up?

The usual way to do this is to use your personal fork to create the PR then there is no branch to clean up

crowmagnumb commented 1 month ago

Hey all what's the status here. The dependency issue cropped up again with my teammate (our loophole seems to not work again). Let me know if I can help in any way to get this moving forward. Cheers.

kdubb commented 1 month ago

@davidwheeler123 Updated the dependencies in #578, there has been no release yet.

davidwheeler123 commented 1 month ago

The dependencies were updated nearly a year ago so I'll probably need to do it again - there's likely new CVEs cropped up since the last update.

crowmagnumb commented 1 month ago

Yes please, in particular io.netty is at 4.1.109.Final now. :)

kdubb commented 1 month ago

@davidwheeler123 Thank you for pitching in... a year to get that PR 🤦‍♂️🤷‍♂️.