imposters-handbook / feedback

General typos, issues, clarifications etc for The Imposter's Handbook
78 stars 2 forks source link

Cycle in graphs #190

Closed bobosola closed 7 years ago

bobosola commented 7 years ago

On pages 245 & 249 you demonstrate a cycle in a graph with the comment this path is a cycle. But it looks to me (from my non-CS educated POV) that the opposed directional arrows of the bottom left vertex actually make it non-cyclic? In other words, you can’t traverse the highlighted path from any vertex in the path and end up at the starting vertex?

It’s entirely possible that I have misunderstood the meaning of a cycle here. So could please clarify why it is in fact a cycle despite the directional constraints, or maybe correct it if it isn’t? Fabulous book by the way - I’m enjoying the occasional offsite links like the mind-blowing Jim Weirich keynote almost as as much as the content. Great stuff!

chrisseaton commented 7 years ago

Yes, there is no cycle as illustrated on his page.

The grey line shows a cycle moving along an orange line that is directed the other way.

robconery commented 7 years ago

Yeah this is a goofy bug - thanks for reporting... fixed for next rev.