imposters-handbook / feedback

General typos, issues, clarifications etc for The Imposter's Handbook
78 stars 2 forks source link

Typo in v2.2.0 EPUB, Big O, The Not So Good Approach: O(N^2) #270

Closed hughbien closed 3 years ago

hughbien commented 3 years ago

In the Chapter "Big O", in the section "The Not So Good Approach: O(N^2)".

The code example is:

const hasDuplicates = function(num){

I think num parameter should be pluralized, because the argument is actually an array of numbers and nums is referenced in the function body.

robconery commented 3 years ago

Nice catch! Agree - thanks!

robconery commented 3 years ago

Cheers thanks!